Skip to content

Set projectType in CodeGenerator properly everywhere #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

Set projectType in CodeGenerator properly everywhere #1997

merged 3 commits into from
Mar 21, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Mar 21, 2023 •
edited
Loading

Description

Fixes # (1987)

How to test

Automated tests

  • UtBotJavaApiTest
  • SarifGradleExtensionProviderTest (added new tests)
  • SarifMavenConfigurationProviderTest (added new test)

Some tests for Spring support should be added after full Spring support.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-sarif Issue is related to SARIF report or Problems tab labels Mar 21, 2023
@EgorkaKulikov EgorkaKulikov requested a review from mmvpm March 21, 2023 08:24
@EgorkaKulikov EgorkaKulikov changed the title Set projectType in CodeGenerator properly everywhere. Set projectType in CodeGenerator properly everywhere Mar 21, 2023
mmvpm
mmvpm requested changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@mmvpm mmvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please, update the documentation at utbot-maven/docs/ and at utbot-gradle/docs/
  2. And add new tests to
    • org.utbot.gradle.plugin.extension.SarifGradleExtensionProviderTest
    • org.utbot.maven.plugin.extension.SarifMavenConfigurationProviderTest

@EgorkaKulikov EgorkaKulikov force-pushed the egor/further_projecttype_usage branch from 2cc7ee9 to ca05fad Compare March 21, 2023 09:23
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 21, 2023 10:18
@EgorkaKulikov EgorkaKulikov merged commit bfc2de9 into main Mar 21, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/further_projecttype_usage branch March 21, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmvpm mmvpm mmvpm approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator comp-sarif Issue is related to SARIF report or Problems tab ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorkaKulikov @mmvpm